Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove longstanding comment from C# console template #42497

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

baronfel
Copy link
Member

@baronfel baronfel commented Aug 1, 2024

Fix #36293 by removing this old comment.

@baronfel baronfel requested a review from a team as a code owner August 1, 2024 15:22
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Aug 1, 2024
@stephentoub
Copy link
Member

@baronfel
Copy link
Member Author

baronfel commented Aug 1, 2024

Yep - I authored this quickly from the web so was using CI as a gate to see what else needed doing while I worked on other things today. The approval tests will certainly need updating, but the static testassets can stay, as those are point-in-time resources used for other scenario-based tests.

@baronfel baronfel enabled auto-merge (squash) August 23, 2024 20:17
},
"ContainerBaseImage": {
"type": "string",
"defaultValue": "mcr.microsoft.com/dotnet/runtime:8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.0 intentional since this is main?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that file shouldn't even be checked in, it's not relevant to this template change at all. Let me revert it.

@marcpopMSFT
Copy link
Member

@baronfel is this for 9 or 10?

@baronfel
Copy link
Member Author

It was gonna be for 9 but I am not at all sure I'll be able to get to it in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
5 participants