-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove longstanding comment from C# console template #42497
base: main
Are you sure you want to change the base?
Conversation
Might need to touch a few more files? |
Yep - I authored this quickly from the web so was using CI as a gate to see what else needed doing while I worked on other things today. The approval tests will certainly need updating, but the static testassets can stay, as those are point-in-time resources used for other scenario-based tests. |
}, | ||
"ContainerBaseImage": { | ||
"type": "string", | ||
"defaultValue": "mcr.microsoft.com/dotnet/runtime:8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.0 intentional since this is main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that file shouldn't even be checked in, it's not relevant to this template change at all. Let me revert it.
@baronfel is this for 9 or 10? |
It was gonna be for 9 but I am not at all sure I'll be able to get to it in time. |
Fix #36293 by removing this old comment.